usnistgov / NFIQ2

Optical live-scan and ink fingerprint image quality assessment tool
https://www.nist.gov/services-resources/software/development-nfiq-20
Other
129 stars 57 forks source link

Remove minimum image dimensions #309

Closed gfiumara closed 2 years ago

gfiumara commented 2 years ago

Minimum image dimensions were imposed to work around a limitation of FingerJet FX OSE. The feature extractor does not mind having blank whitespace around a fingerprint though. This change pads the fingerprint image to the bottom and right of the 29794-4 mandated cropped version such that minutiae can be extracted. Minutiae found that are not within the 29794-4 mandated cropped version of the image are removed before the other minutiae-based features are computed.

github-actions[bot] commented 2 years ago

:white_check_mark: Conformance regression test passed on all tested platforms.

github-actions[bot] commented 2 years ago

:white_check_mark: Conformance regression test passed on all tested platforms.

gfiumara commented 2 years ago

2m+ sequestered dataset sees 13,076 images gain a quality score, 48 produce a FingerJet FX error about being too small (as opposed to an NFIQ 2 error), and no other differences. Ready to merge.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for ubuntu-20.04 (x64) failed. Please review the artifacts for this run.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for ubuntu-18.04 (x64) failed. Please review the artifacts for this run.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for windows-2016 (x64) failed. Please review the artifacts for this run.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for windows-2019 (x64) failed. Please review the artifacts for this run.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for windows-2016 (x86) failed. Please review the artifacts for this run.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for windows-2019 (x86) failed. Please review the artifacts for this run.

github-actions[bot] commented 2 years ago

:x: Conformance regression test for macOS-10.15 (x64) failed. Please review the artifacts for this run.

gfiumara commented 2 years ago

CTS errors due to fix from #308 being merged and now detecting the differences from the smaller images in the CTS. Ignore.