search

usnistgov / NFIQ2

Optical live-scan and ink fingerprint image quality assessment tool
https://www.nist.gov/services-resources/software/development-nfiq-20
Other
129 stars 57 forks source link

Refactor addHistogramFeatures #317

Closed gfiumara closed 2 years ago

gfiumara commented 2 years ago

Modernize some of addHistogramFeatures().

Closes #310 by providing a better error message when no observations are available in FDA. Note that the histogram bin size check for FDA only occurs in FDA because FDA is currently the first feature computed. There's likely a better way to add these histogram features, and so I'm just doing the minimum now to get the better message.

github-actions[bot] commented 2 years ago

:white_check_mark: Conformance regression test passed on all tested platforms.

gfiumara commented 2 years ago

No change on 2m+ dataset, with the exception of the new error message on a blank image.