search

usnistgov / NFIQ2

Optical live-scan and ink fingerprint image quality assessment tool
https://www.nist.gov/services-resources/software/development-nfiq-20
Other
129 stars 57 forks source link

support bmp for cli, add imgcodecs to opencv build #328

Closed RLessmann closed 2 years ago

RLessmann commented 2 years ago

please add the imgcodecs library to the opencv build, so command line apps can use opencv to load images and do not need to re-integrate opencv for this purpose.

github-actions[bot] commented 2 years ago

:white_check_mark: Conformance regression test passed on all tested platforms.

gfiumara commented 2 years ago

Hi @RLessmann, can you confirm this actually does what you want? The top-level CMakeLists.txt still has configuration options like WITH_PNG=OFF BUILD_PNG=OFF, meaning that the only formats supported by building the imgcodecs module are the built-in types (notably: BMP and PGM).

I also have some concern that the third-party codecs from OpenCV, if re-enabled, are going to clash with those that are static-linked into libbiomeval. We should make a simple test program that uses both libbiomeval image parsing and OpenCV image processing in the same app to confirm nothing bad happens.

gfiumara commented 2 years ago

Linking related issue #265.

RLessmann commented 2 years ago

The built in types should be efficient enough. I also do not like to add dependencies to the typica third party formats like png. So lets stick with the built in types only.

gfiumara commented 2 years ago

@RLessmann Okay, then there should be no issues! Merging.