search

usnistgov / NFIQ2

Optical live-scan and ink fingerprint image quality assessment tool
https://www.nist.gov/services-resources/software/development-nfiq-20
Other
129 stars 57 forks source link

fixed forwarding of required cmake flags for iOS #331

Closed RLessmann closed 2 years ago

RLessmann commented 2 years ago

a) OpenCV changed the handling of the iOS toolchain and the flag CMAKE_SYSTEM_PROCESSOR is now required

b) Force enabling bit code for iOS

c) OpenCV 4.5.4 defined BUILD_opencv_apps with lower case letters. When cross compiling on iOS, uppercase definition did not trigger and the compilation of the cmake apps will fail during cross compilation

github-actions[bot] commented 2 years ago

:white_check_mark: Conformance regression test passed on all tested platforms.

gfiumara commented 2 years ago

Merging, but let's keep an eye on this change as we clean up the CMake build (I think I may have already removed IOS_CMAKE_ARGS in a local clean-up branch). As far as the case of BUILD_opencv_apps, I bet that is an auto-generated CMake arg based on the name of the target, which will likely stay lowercase, so we can remove the other. I'll leave this all as-is for now since we're not actively testing or releasing iOS builds on GitHub at this time.

For future reference when we do add support for iOS on GitHub: what effect if any does bitcode have on conformance testing on device?

RLessmann commented 2 years ago

Hi, just for the bitcode on iOS. Generating bitcode is true by default, but the toolchain warns about the missing flag. We are always using generating bitcode on projects, and I did not experience negative side effects by now. Thx Ralph