search

usnistgov / NFIQ2

Optical live-scan and ink fingerprint image quality assessment tool
https://www.nist.gov/services-resources/software/development-nfiq-20
Other
129 stars 57 forks source link

unused variable #346

Open maddin200 opened 1 year ago

maddin200 commented 1 year ago

NFIQ2/NFIQ2Algorithm/src/nfiq2/nfiq2_qualityfeatures_impl.cpp line 76 Code: std::unordered_map<std::string, double> NFIQ2::QualityFeatures::Impl::getQualityFeatureValues( const std::vector<std::shared_ptr> &features) { std::vector qualityIdentifiers = NFIQ2::QualityFeatures::Impl::getQualityFeatureIDs(); // <- assigned but unused

std::unordered_map<std::string, double> quality {};

for (const auto &feature : features) {
    const auto moduleFeatures = feature->getFeatures();
    quality.insert(moduleFeatures.cbegin(), moduleFeatures.cend());
}

return quality;

}

gfiumara commented 1 year ago

Thanks. Let's link to #134, which would likely expose this as well