search

usnistgov / NISTIR-8112

Attribute Metadata Publication
4 stars 11 forks source link

Overall looks great. Very few edits, and only the few comments below.… #75

Closed garciamike closed 6 years ago

garciamike commented 6 years ago

Terrific work. Let’s ship this pup.

Lots of dangling SP language. Need to update for NISTIR, especially in cover_front.

A number of section references in which we call them “subsections” rather than “sections” and do not link. To be consistent with -63 conventions, call all subsections “Section X.Y” and link appropriately.

I did not review references careful, but it does seem at least the first one is rendering strangely, at least in macdown.

Y’all can decide if you want to update the dates in the examples before publishing :)

paul-grassi commented 6 years ago

@RGalluzzo you want to look before I merge? Any chance you can get Danna or someone to jump in on the comments Mike made? I can do it on plane home, or we can ask Katie.

RGalluzzo commented 6 years ago

Merge away. Will figure out who to have look at the comments.