usnistgov / OSCAL-Pages

Open Security Controls Assessment Language (OSCAL) Website Content
https://pages.nist.gov/OSCAL/
Other
7 stars 14 forks source link

Fix bad newline in profile resolution shortcode #39

Closed aj-stein-nist closed 1 year ago

aj-stein-nist commented 1 year ago

PR #36 for issue #1900 did rightfully update the profile resolution specification, but it appears there is a newline I did not observe when reviewing the PR for the terminating highlight shortcode. Line 166 and 167 should be combined from the original here.

https://github.com/usnistgov/OSCAL-Pages/pull/36/files#diff-e17d032b140290e1a093c3eca4af6a6bc9b342eac605b349466da5089595fde9R166

If this is not modified, the bad shortcode directive bakes the website build.

$ git rev-parse HEAD
4e9f6b3499f44260472ca63f3173f5fe0cf39f05
$ hugo server -s ./src --enableGitInfo=false --verbose --debug --minify --disableFastRender
Start building sites … 
hugo v0.111.0-3fa8bb8318114cd69315eadd35bda169e6a8ca4b+extended linux/amd64 BuildDate=2023-03-01T20:57:44Z VendorInfo=gohugoio
INFO 2023/08/30 16:46:53 syncing static files to /
Error: Error building site: "/home/me/code/oscal-pages/branches/me/develop/src/content/concepts/processing/profile-resolution.html:166:57": failed to extract shortcode: unclosed shortcode "highlight"
Built in 187 ms

This issue was blocking #35 and is blocking #38.