search

usnistgov / PyHyperScattering

Tools for hyperspectral x-ray and neutron scattering data loading, reduction, slicing, and visualization.
Other
6 stars 8 forks source link

fix for SST1 cycle 2 2023 rsoxs data loading #101

Closed andrewjlevin closed 10 months ago

andrewjlevin commented 11 months ago

3 minor changes to SST1RSoXSLoader to correctly load metadata for SST1 RSoXS measurements during cycle 2 2023. This implementation may break metadata loading from earlier cycles.

pbeaucage commented 10 months ago

@andrewjlevin sorry for the delay in looking at this!

It does look like these will break old data loading, which is no good. Can you add guardrails (try/except or similar) so that the tests pass and it still works on new data? @EliotGann or @pdudenas can probably help with this as well.

andrewjlevin commented 10 months ago

Sorry I didn't mean to close this request, I was just shuffling around branches in the Toney group fork. I'll update the file so that it works with old and new data and then reopen/put in another pull request.

andrewjlevin commented 10 months ago

I've updated the couple of changes to have try/except statements. I just tested it and it works for my local rsoxs data from the recent 2023-2 cycle as well as data I have from 2021 and 2022.