usnistgov / PyHyperScattering

Tools for hyperspectral x-ray and neutron scattering data loading, reduction, slicing, and visualization.
Other
6 stars 8 forks source link

`SST1RSoXSDB`: fix bug described in #121 #122

Closed pbeaucage closed 3 months ago

pbeaucage commented 3 months ago

See description in #121, this changes the dimension hinting code in the following ways:

1) instead of looking at std(scan_values) / mean(scan_values) it now uses abs(std(scan_values)/(max(scan_values)-min(scan_values))

2) time is now a default hinted dimension, so adds a kwarg that by default doesn't include it

3) there might be a few warning/other fixes that don't impact anything but API compatibility in this fix.

One question is whether tests should cover dimension hinting, i.e, that scan # 'x' is really energy/pol and 'y' is sam_x/sam_y. Just need test data on the public server for that.