Closed BijalBPatel closed 1 year ago
Tagging issue #31 which didn't tag in title, weird. Will take a look soon.
The CI failures appear to be an unrelated issue with Python3.8 and xarray. I will open a separate issue and get those fixed.
One request that explicitly should not hold up merging: would you be willing to write a little how-to, largely adapted from the docstring, in the sphinx docs?
If you can think of any ways this method might be unit-tested it would be good to document them as well. Logistically we actually can't unit test this class until there is a public BNL Tiled server, though we could ask Dan Allan to add a rsoxs example to the public Tiled demonstration server. That wouldn't get us a rsoxs catalog, though.
update: you can actually write the test function over in tests/ and then just decorate the functions with @pytest.mark.skip(reason="cannot test until BNL Tiled is public")
Woops - sorry for close/opening, meant to just reply to a comment.
One request that explicitly should not hold up merging: would you be willing to write a little how-to, largely adapted from the docstring, in the sphinx docs?
If you can think of any ways this method might be unit-tested it would be good to document them as well. Logistically we actually can't unit test this class until there is a public BNL Tiled server, though we could ask Dan Allan to add a rsoxs example to the public Tiled demonstration server. That wouldn't get us a rsoxs catalog, though. update: you can actually write the test function over in tests/ and then just decorate the functions with @pytest.mark.skip(reason="cannot test until BNL Tiled is public")
No problem - unless someone else gets to it first, I'll take a crack at the sphinx documentation and tests in a couple of weeks.
Expanded functionality of the summarize_run function in SST1RSiXSDB.py (#31). I believe the signature matches that of the old version, so existing code should remain functional.
New Features:
See signature docstring for full documentation and example functions.