search

usnistgov / PyHyperScattering

Tools for hyperspectral x-ray and neutron scattering data loading, reduction, slicing, and visualization.
Other
6 stars 8 forks source link

ALS 11.0.1.2 file loader - change in "shutter inhibit" name #64

Closed mrlandsman closed 1 year ago

mrlandsman commented 1 year ago

Within ALS11012RSoXSloader.py, the shutter inhibit is defined as 'CCD Shutter Inhibit', but more-recent data collected at 11.0.1.2 use 'CCD Camera Shutter Inhibit instead. Cheng said he thinks this change in the variable name occurred in March 2021 when the camera driver was updated. Can you implement a universal lookup for defining the correct shutter inhibit column name for datasets pre- and post-March 2021?

pbeaucage commented 1 year ago

Thanks for the issue, Matt!

I have a tentative fix for this using a flag in the linked branch. I'd like to add an automated test for this as well. To do this well, I should really add an example newer dataset to the testing data pack. Would you be willing to share a short scan taken on 11.0.1.2 after the change? This data would be publicly hosted in this Git project. We could strip identifying information if you wish.

mrlandsman commented 1 year ago

Thanks for the fix, Peter! I'm attaching a folder with a short (3 energy) carbon edge scan of 300 nm polystyrene spheres that I collected a few days ago. Please let me know if there's anything else I can provide/help with.

PSS300nm_C_ccd100.zip