Status update: I've removed the problematic changes from PFEnergySeriesIntegrator, added some comments that clarify some of the questions @cbishop4 left in the code.
I've also replaced the problematic/rigid logic for auto-inferring dimensions with something that should be quite flexible and hopefully really only pull in dimensions that need to be there.
@cbishop4 plans to add a flag to SST1RSoXSDB.loadRun() that switches between using readback positions and setpoint positions. (RB positions are more correct, but cause issues with scan display and memory consumption). Once that's in, we can tidy up some of the other files and get this merged.
Status update: I've removed the problematic changes from
PFEnergySeriesIntegrator
, added some comments that clarify some of the questions @cbishop4 left in the code.I've also replaced the problematic/rigid logic for auto-inferring dimensions with something that should be quite flexible and hopefully really only pull in dimensions that need to be there.
@cbishop4 plans to add a flag to
SST1RSoXSDB.loadRun()
that switches between using readback positions and setpoint positions. (RB positions are more correct, but cause issues with scan display and memory consumption). Once that's in, we can tidy up some of the other files and get this merged.