search

usnistgov / REFPROP-issues

A repository solely used for reporting issues with NIST REFPROP
26 stars 13 forks source link

P-h plots not plotting decimal values of Entropy #676

Closed Daddownunder closed 1 month ago

Daddownunder commented 3 months ago

If you have an issue to report, please continue and fill out the applicable sections below. The details provided will help to resolve this issue as quickly as possible.

Prerequisites

NOTE: Be aware that all issues are publicly accessible and viewable. Thus please do not post any code or other content that is protected intellectual property or under copyright.

Before posting an issue, please:

You can also use markdown to format your issue: GitHub guide on Markdown. If you have code snippets, please use a code block to ensure that the formatting remains legible in the web interface. For instance, surround your code in triple backticks:

print('Hello world!')

P-h plots not plotting decimal values of Entropy

[Description of the issue]

Steps to Reproduce

  1. Open new P-h plot 2.set up parameters Entropy step 0.1
  2. [and so on...]

Expected behavior: Expect a plot with Entropy plotted every 0.1 kJ/kg/K

Actual behavior: Plots every 1 kJ/kg/K

Versions

REFPROP 10.0 recently downloaded Operating System and Version: Windows 11 Access Method:** PC app

Additional Information

Uninstalled REFPROP and reinstalled no effect

image

image

ianhbell commented 3 months ago

Did you also try 0.1 as the step?

nist-aharvey commented 3 months ago

This must have been fixed at some point; it works correctly with the December 4 2021 beta and DLL Version 10.0.0.98b, using exactly the same specs as in the example:

image

Strangely, I cannot reproduce the bug in mini-REFPROP, which I would have expected to match REFPROP 10.0. And I note that the plot and the Setup window in the report don't match each other (for example, the axis limits), which makes me wonder if there might have been a user error.

Daddownunder commented 3 months ago

This was not a problem until I changed over to Windows 11 and reinstalled REFPROP after having a problem with excel looking up properties

Dave Bond +66 62 242 3837

From: Allan Harvey @.> Sent: Tuesday, 6 August 2024 02:39 To: usnistgov/REFPROP-issues @.> Cc: Daddownunder @.>; Author @.> Subject: Re: [usnistgov/REFPROP-issues] P-h plots not plotting decimal values of Entropy (Issue #676)

This must have been fixed at some point; it works correctly with the December 4 2021 beta and DLL Version 10.0.0.98b, using exactly the same specs as in the example:

image.png (view on web)https://github.com/user-attachments/assets/c05e8e78-d498-4cfe-9462-1bbaf1f9dedd

Strangely, I cannot reproduce the bug in mini-REFPROP, which I would have expected to match REFPROP 10.0. And I note that the plot and the Setup window in the report don't match each other (for example, the axis limits), which makes me wonder if there might have been a user error.

- Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/REFPROP-issues/issues/676#issuecomment-2269778067, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKJYPHUXP7FXFD2XRMCYM7TZP7IDVAVCNFSM6AAAAABL6PWEMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZG43TQMBWG4. You are receiving this because you authored the thread.Message ID: @.**@.>>

Daddownunder commented 3 months ago

I have always used 0.1 as the step, this is when the issue appeared. It only appeared after I uninstalled REFPROP and reinstalled it because I was having an issue with getting properties in excel. The reinstallation fixed the excel issue but then the 1 step turned up even when I was using 0.1

Dave Bond +66 62 242 3837

From: Ian Bell @.> Sent: Monday, 5 August 2024 19:22 To: usnistgov/REFPROP-issues @.> Cc: Daddownunder @.>; Author @.> Subject: Re: [usnistgov/REFPROP-issues] P-h plots not plotting decimal values of Entropy (Issue #676)

Did you also try 0.1 as the step?

- Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/REFPROP-issues/issues/676#issuecomment-2268942892, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKJYPHVV5ILOTZCXODT4SNDZP5U5LAVCNFSM6AAAAABL6PWEMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYHE2DEOBZGI. You are receiving this because you authored the thread.Message ID: @.**@.>>

ianhbell commented 3 months ago

Sounds like a localization issue perhaps. Can you try 0,1 as your step?

Daddownunder commented 3 months ago

That solved it. The panel shows 0.1 but works with 0,1. What do I need to change in windows to prevent this issue?

ianhbell commented 3 months ago

Not sure; you'll have to do some googling. You are looking for something about decimal delimiter.

nist-aharvey commented 3 months ago

There is also a setting in REFPROP under Options, Preferences, for "Flip usage of commas and periods in numbers". You might see how that is set and try the other setting to see what happens. Looking closely at the Setup window you pasted in, it looks like REFPROP is using commas for the decimal marker (for example, see the y-axis range that has a 0,5), so either that Preferences setting has gotten set or else your Windows thinks you are in continental Europe or some other place that uses the comma as the decimal marker. [You might try going into Excel and computing 1/2 to see how it writes the result.]

Edited to Add: In Windows 11, it appears that you get to the relevant settings via Settings ... Time & Language ... Language & Region.

Daddownunder commented 3 months ago

Firstly, I found out how to change the comma setting to a period in windows: How to Change the Windows 11 List Separator: A Step-by-Step Guide - Support Your Techhttps://www.supportyourtech.com/tech/how-to-change-the-windows-11-list-separator-a-step-by-step-guide/

Having done that tried to plot a p-h plot of CO2 using default settings: @. Note all setting now with periods not commas in Entropy. Get this plot with no Entropy plotting @. Add decimal numbers in Step in entropy @. This gives this plot: @. There is either something else affecting the plot in Windows 11 or a bug.

Thanks for the help at least I can get back to plotting p-h plots

Dave Bond +66 62 242 3837

From: Allan Harvey @.> Sent: Tuesday, 6 August 2024 21:22 To: usnistgov/REFPROP-issues @.> Cc: Daddownunder @.>; Author @.> Subject: Re: [usnistgov/REFPROP-issues] P-h plots not plotting decimal values of Entropy (Issue #676)

There is also a setting in REFPROP under Options, Preferences, for "Flip usage of commas and periods in numbers". You might see how that is set and try the other setting to see what happens. Looking closely at the Setup window you pasted in, it looks like REFPROP is using commas for the decimal marker (for example, see the y-axis range that has a 0,5), so either that Preferences setting has gotten set or else your Windows thinks you are in continental Europe or some other place that uses the comma as the decimal marker. [You might try going into Excel and computing 1/2 to see how it writes the result.]

- Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/REFPROP-issues/issues/676#issuecomment-2271420578, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKJYPHUEGV3HZFNIXWXAOB3ZQDLXTAVCNFSM6AAAAABL6PWEMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGQZDANJXHA. You are receiving this because you authored the thread.Message ID: @.**@.>>

ianhbell commented 3 months ago

You'll need to use the web interface to attach the images

Daddownunder commented 3 months ago

Firstly, I found out how to change the comma setting to a period in windows: How to Change the Windows 11 List Separator: A Step-by-Step Guide - Support Your Tech

Having done that tried to plot a p-h plot of CO2 using default settings:

image

Note all setting now with periods not commas in Entropy. Get this plot with no Entropy plotting

image

Add decimal numbers in Step in entropy

image

This gives this plot:

image

There is either something else affecting the plot in Windows 11 or a bug.

Thanks for the help at least I can get back to plotting p-h plots