usnistgov / REFPROP-wrappers

Wrappers around NIST REFPROP for languages such as Python, MATLAB, etc.
193 stars 127 forks source link

Refactor Mathematica wrapper structure for Pactlet generation in MM13+ #576

Closed henningjp closed 9 months ago

henningjp commented 10 months ago

This is a complete restructuring of this wrapper to support the modern Paclet generation in Mathematica 13 and higher (current release is 14.0). This is a long awaited change from Wolfram on the Mathematica product. Actual code functionality has not changed at all, but unfortunately the entire wrapper directory will look like it's been tossed and completely replaced. Since it is Wolfram Language code and the new help page templates contain many formatting changes, looking at these diffs will not be helpful.

Benefits:

Changes:

Testing and Verification

ianhbell commented 9 months ago

Is this all ready to merge?

henningjp commented 9 months ago

Yes.

I've been sitting on this PR until MM v14 was released (which is also tested) so this restructure didn't require the latest cutting edge release. We're a major and minor release past the required v13.2. I've been using these changes for almost a year now, with no side effects.

ianhbell commented 9 months ago

One last question: does it make sense to keep the old files around somewhere? Move them into a subfolder or something?

henningjp commented 9 months ago

Can't someone just checkout the previous commit in the history? Not sure who would want to, unless they only have MM 12. Even it won't run on anything earlier than 12.

Also, I'm working on putting the installation paclet on the Wolfram Paclet Server for even easier access to the new version.

ianhbell commented 9 months ago

Suppose so. I'll go ahead and merge.

henningjp commented 9 months ago

If you want to, let's put some tags on to make it easier to find.

Tag the commit in this last PR commit (1237f7f4c571fe86f5572f31314e633acdc1889c) as Mathematica v1.1, Then tag my last previous commit (7e0384c787a825db2ab42ae1b19cf60e930330d7) as Mathematica 1.0.

I don't think I can do that easily from here.

ianhbell commented 9 months ago

Ok, I did the tagging you suggest : https://github.com/usnistgov/REFPROP-wrappers/tags (spaces not permitted in tag names)

Happiness-in-Danger commented 8 months ago

@henningjp In MMA14,there are some problems. image

henningjp commented 8 months ago

@Happiness-in-Danger - You should open an actual Issue for this, rather than adding a comment to this pull request.

I'm running on MMA14 (14.0.0.0 to be exact) with no issues.

Your screenshot error message indicates that NIST REFPROP is not found or you have an older version, or possibly it's not inthe default location on your machine.

The Needs command should come back with: image

If you don't see that green banner, the wrapper couldn't find REFPROP.

Also, REFPROP v9.1 or v10.0 must be installed. The error message you are getting indicates that it can't determine the version of NIST REFPROP that you are using. Versions earlier than v9.1 are not supported.

Please open an Issue with your original post and indicate which version of NIST REFPROP you have.