md-eval.pl tests don't work under perl >= 5.26

[jtrmal]

Hi, one of our (Kaldi) contributors has found and reported sctk issue for perl See here: https://github.com/kaldi-asr/kaldi/pull/2246

I looked at the code and it seems there is actually a bug in the code (src/md-eval/md-eval.pl): instead of

1099     $word->{WORD} =~ lc $word->{WORD}; #lower case

I believe it should say

1099     $word->{WORD} = lc $word->{WORD}; #lower case

Do you want me to create PR or are you fixing it by yourselves?

[jfiscus]

Jan,

I found that one too … after staring at if for a loooooong time. Please make a PR. That’ll help a lot.

-Jon

From: jtrmal notifications@github.com Reply-To: usnistgov/SCTK reply@reply.github.com Date: Thursday, March 1, 2018 at 10:29 AM To: usnistgov/SCTK SCTK@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [usnistgov/SCTK] md-eval.pl tests don't work under perl >= 5.26 (#3)

Hi, one of our (Kaldi) contributors has found and reported sctk issue for perl See here: kaldi-asr/kaldi#2246https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkaldi-asr%2Fkaldi%2Fpull%2F2246&data=02%7C01%7Cjonathan.fiscus%40nist.gov%7C0de9616e8d1a4f8d66ab08d57f892321%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C636555149395621191&sdata=t%2BxsXEwuibeUzhrxnsojJCbz2LalRADQeuR6UKdl2Q8%3D&reserved=0

I looked at the code and it seems there is actually a bug in the code (src/md-eval/md-eval.pl): instead of

1099 $word->{WORD} =~ lc $word->{WORD}; #lower case

I believe it should say

1099 $word->{WORD} = lc $word->{WORD}; #lower case

Do you want me to create PR or are you fixing it by yourselves?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fusnistgov%2FSCTK%2Fissues%2F3&data=02%7C01%7Cjonathan.fiscus%40nist.gov%7C0de9616e8d1a4f8d66ab08d57f892321%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C636555149395621191&sdata=V1LAHyP%2Bh5UM%2F%2F%2BL0MfPe4m36Tq8ZzA9H8FuHlR3ISo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJxUYbfN-UTC7MK92sFB6zbV6E1oes_Qks5taBOwgaJpZM4SYfeP&data=02%7C01%7Cjonathan.fiscus%40nist.gov%7C0de9616e8d1a4f8d66ab08d57f892321%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C636555149395621191&sdata=6iN%2FllLdvCuIYnDJ5cUlBnZrt4fvAHI8V4b2rCBMfqY%3D&reserved=0.

[jfiscus]

This was corrected by jtrmal-sctk_fix merge request.