search

usnistgov / SP800-90B_EntropyAssessment

The SP800-90B_EntropyAssessment C++package implements the min-entropy assessment methods included in Special Publication 800-90B.
195 stars 88 forks source link

Inconsistent variable with usage #202

Closed Zalamar closed 1 year ago

Zalamar commented 1 year ago

Mix between using FileLength and FileLen breaking the compilation, just changed all to FileLen.

joshuaehill commented 1 year ago

I reviewed the change. , and don't see any reason why the original code should have caused a problem. (More to the point, the changes you made shouldn't change anything after compilation). What compiler are you using, and what was its error message?

On a broader check, this is all new code, and couldn't have ever possibly compiled. It's not all that clear what use case this code is intending to support, but it clearly hasn't been internally compiled or tested.

joshuaehill commented 1 year ago

I added a PR that addresses all of the bugs that I saw in the sha256_file() function, including the one fixed in this PR.

@celic If you merge PR #204, you don't need to merge this PR. Duplicate of #204

andrewmccaffreynist commented 1 year ago

Not merged as the fixes were incorporated/superseded by #204

joshuaehill commented 1 year ago

@andrewmccaffreynist I think that this PR can be closed.

andrewmccaffreynist commented 1 year ago

Thanks!