usnistgov / SP800-90B_EntropyAssessment

The SP800-90B_EntropyAssessment C++package implements the min-entropy assessment methods included in Special Publication 800-90B.
202 stars 88 forks source link

Addressed some bugs introduced in the `sha256_file()` function #204

Closed joshuaehill closed 1 year ago

joshuaehill commented 1 year ago

These bugs were introduced in 43f759db4751655ecc0f3d995ccbae9d6d5ff4e3

There were a few issues:

I propose that future changes be compiled and run on data at least once prior to checking in the code, particularly when the code is going into the master branch.

Resolves usnistgov/SP800-90B_EntropyAssessment#203 Resolves usnistgov/SP800-90B_EntropyAssessment#205 Resolves usnistgov/SP800-90B_EntropyAssessment#206 Resolves usnistgov/SP800-90B_EntropyAssessment#210 Resolves usnistgov/SP800-90B_EntropyAssessment#211

joshuaehill commented 1 year ago

After looking reviewing the OpenSSL deprecated API set, I think that there is a way to accomplish this task in a way that is similar to the prior approach (which required a much smaller buffer). I've updated the PR to use this parallel approach.

I also caught a few other problems (Issues #211 and #210) and included the fixes for these problems here as well.

@celic If you would prefer that I make distinct pull requests, let me know.