search

usnistgov / SP800-90B_EntropyAssessment

The SP800-90B_EntropyAssessment C++package implements the min-entropy assessment methods included in Special Publication 800-90B.
202 stars 87 forks source link

First round of permutation test fixes #80

Closed joshuaehill closed 5 years ago

joshuaehill commented 6 years ago

This pull request resolves an "off by 1" problem for counting runs and a couple of problems in the compression permutation test (a string construction problem and a buffer length problem).

I'm still seeing mismatches in the tests that aren't invariant under translation, so that problem could also be masking other problems.

As of Oct 1, this pull request Closes #78, closes #79, closes #82, closes #61.

joshuaehill commented 6 years ago

At this point, I think that this pull request closes all the permutation issues that I currently know about.

celic commented 5 years ago

Hi Josh, I'm going through the PRs and this one has some conflicts. Would you be able to take a look when you have a chance?

joshuaehill commented 5 years ago

Sure, I'll take a look this evening.

joshuaehill commented 5 years ago

OK, I rebased off the current NIST master branch, and then fixed the merge issues. This pull request should merge cleanly now...