search

usnistgov / SpectrumBrowser

ITL
12 stars 11 forks source link

Change accounts, temp accounts, and temp passwords to not use text strings for field names #131

Closed jkubNTIA closed 9 years ago

jkubNTIA commented 9 years ago

Ranga suggested that we change all mongoDB field names to be stored in one place for accounts, temp accounts, and temp passwords.

Does it make more sense to store these database field name strings in Defines.py or in Message.py? What do you think, Ranga?

ranganathanm commented 9 years ago

I have been putting all global string constants in Defines.py. A little coarse grained but gets the job done.

From: jkub01 notifications@github.com Sent: Monday, March 9, 2015 11:35 AM To: usnistgov/SpectrumBrowser Subject: [SpectrumBrowser] Change accounts, temp accounts, and temp passwords to not use text strings for field names (#131)

Ranga suggested that we change all mongoDB field names to be stored in one place for accounts, temp accounts, and temp passwords.

Does it make more sense to store these database field name strings in Defines.py or in Message.py? What do you think, Ranga?

Reply to this email directly or view it on GitHubhttps://github.com/usnistgov/SpectrumBrowser/issues/131.

jkubNTIA commented 9 years ago

I could not remember if you wanted me to put these in Defines.py or you wanted me to put them in Message.py, since you were trying to move towards more of a get/set structure. Should I start out in Defines.py for now and move to Message.py later?

ranganathanm commented 9 years ago

Yes. Lets put these strings in Defines.py.

We are going to do some refactoring later.

From: jkub01 notifications@github.com Sent: Monday, March 9, 2015 11:39 AM To: usnistgov/SpectrumBrowser Cc: Ranganathan, Mudumbai Subject: Re: [SpectrumBrowser] Change accounts, temp accounts, and temp passwords to not use text strings for field names (#131)

I could not remember if you wanted me to put these in Defines.py or you wanted me to put them in Message.py, since you were trying to move towards more of a get/set structure. Should I start out in Defines.py for now and move to Message.py later?

Reply to this email directly or view it on GitHubhttps://github.com/usnistgov/SpectrumBrowser/issues/131#issuecomment-77877710.

jkubNTIA commented 9 years ago

This is done for the accounts, temp passwords, and temp accounts mongo strings.