usnistgov / SpectrumBrowser

ITL
12 stars 11 forks source link

Check privilege when checking Session ID. #144

Closed ranganathanm closed 9 years ago

ranganathanm commented 9 years ago

currently checkSessionId does not check privilege. Thus a user can acquire a session id and perform admin functions. This is a security hole. Solution is to add a "privilege" (i.e. "user" or "admin") to each flask entry point. When the session ID is checked, we need to check this privilege field as well.

jkubNTIA commented 9 years ago

Good point. Since the privilege is in the first part of the sessionID, this would be really easy to check.

ranganathanm commented 9 years ago

Fixed in ca4cfb6..396abb9