search

usnistgov / SpectrumBrowser

ITL
12 stars 11 forks source link

Use DaemonContext for services and remove bin shell scripts. #214

Closed ranganathanm closed 9 years ago

ranganathanm commented 9 years ago

Python services should use DaemonContext for starting. Remove the existing bin files and redo the service startup using the python daemon package.

ranganathanm commented 9 years ago

Some issues remain :

  1. Admin still runs as root. This is because it needs to start/stop services. This should be fixed.
  2. nginx does not come up as a service.
  3. Services do not start up on reboot.
ranganathanm commented 9 years ago

I will take on #1.

Assigning 2 and 3 to Kheri. It all runs now and I can access admin and sepctrumbrowser. Please check out the issues above. Before you push changes please make sure you test your changes out. master should always be in a bootable state. Regression tests need to be run before you push your changes. You should make sure the system works before you push changes. It does not have to be carefully tested but you need to do a few tests to make sure you have not broken things when you push your changes.

Thanks.

ranganathanm commented 9 years ago

Daemon context has problems when the pid files are not cleaned up on shutdown (using kill -9)

ranganathanm commented 9 years ago

commit 29c23e0e4b40f51d401be56630c87450d5106f46 Fixed issues.