usnistgov / asbestos

13 stars 4 forks source link

enable and update tests to run with testscript #224

Open oliveregger opened 9 months ago

oliveregger commented 9 months ago

@skbhaskarla : we are evaluation the use of TestScript resources in asbestos and have noticed that the tests were not running through. we tried to adaptethem back to running.

2 notes:

if you have any questions to the PR do not hesitate to contact me.

skbhaskarla commented 9 months ago

Thanks @oliveregger

FYI There is a local branch for the XDS Toolkit which uses JDK 16 to compile the source code. It compiles and runs but there is a problem with running the code under the Google GWT debugger, which needs to be fixed for a complete development environment experience. One more thing to update is to fully remove the log4j dependency as both the Maven project compile time and runtime dependency. The current XDS Toolkit release runtime has a patched version log4j to mitigate security risk by removing the vulnerable log4j Java classes from the Java package. The vulnerable log4j classes are not used. When the toolkit release script is run, it removes those vulnerable log4j Java classes and creates a new log4j patched JAR file. I have already converted log4j API references to the Java standard logging in the main Toolkit XDS code and evident in the release notes. The only reason to still have the log4j is the XDS-I transitive package dependency through dcm4che Maven package. Maybe this dependency can be removed altogether in a future release because XDS-I is not maintained any longer in the XDS Toolkit. Once these issues are fixed, the next step will be to update the FHIR Toolkit source code project, because it uses the XDS Toolkit API for the IHE ITI MHD simulator backend, it will need to use the same new JDK compiler.