usnistgov / fipy

FiPy is a Finite Volume PDE solver written in Python
http://pages.nist.gov/fipy/en/latest
Other
510 stars 149 forks source link

Shift CI from eggs to wheels #860

Closed guyer closed 2 years ago

guyer commented 2 years ago
guyer commented 2 years ago

Qt failures have nothing to do with this PR. #862 conda-forge/pyqt-feedstock#112

guyer commented 2 years ago
wd15 commented 2 years ago

Doesn't look like there is anything I can try out or run in this PR so approving. Also can't find any problems just by browsing the diffs.

wd15 commented 2 years ago

Maybe squash some of the commits. Lot of commits for a limited number of changes.

wd15 commented 2 years ago

Could have a single CI commit and a single documentation commit for example.

guyer commented 2 years ago

Could have a single CI commit and a single documentation commit for example.

Thanks. I always squash and merge these days. I decided that the separate commits didn't really stand alone (the docs would be wrong without the CI changes and vice-versa).