search

usnistgov / fipy

FiPy is a Finite Volume PDE solver written in Python
http://pages.nist.gov/fipy/en/latest
Other
504 stars 148 forks source link

WIP: Propogate boundary conditions to old values #921

Open Maxwellfire opened 1 year ago

Maxwellfire commented 1 year ago

Draft WIP:

Currently fipy does not apply boundary conditions to the old values stored in variables. This means that when you compute some metrics (like the time derivative of a quantity on the boundary), you don't get the expected answer.

I'm making this draft pull request to start a conversation and see if this is something that would be helpful to contribute upstream once polished up. I've been using these changes locally for a while.

guyer commented 1 year ago

Thanks for the proposal! This sounds like a reasonable thing to do.

Before merging, I'll need to figure out why the CI has fallen over (and why it hasn't notified me for the last month that it isn't working) and make sure that we get clean tests.

guyer commented 1 year ago

@Maxwellfire: I've finally fixed the CI (#925) and your code both passes and seems like a good idea. Would you like to submit this PR for review?

Maxwellfire commented 1 year ago

@guyer I think that I should include some code that accounts for deleting boundary conditions as well, and take a final check that my code covers all the cases. Once I do that, I'll submit for review

guyer commented 8 months ago

Checking in to see if you've had a chance to polish this PR?