usnistgov / hl7-diff-tool-frontend

0 stars 1 forks source link

Difference in value set not caught #21

Closed carolinerosin closed 2 years ago

carolinerosin commented 2 years ago

Element is MSH-11.2. XML files:profiles.zip

image

here's my source XML

<ValueSetDefinition BindingIdentifier="HL70207" Name="Processing mode">
    <ValueElement Value="A" CodeSystem="HL70207" DisplayName="Archive"/>
    <ValueElement Value="I" CodeSystem="HL70207" DisplayName="Initial load"/>
    <ValueElement Value="Not present" CodeSystem="HL70207" DisplayName="Not present (the default, meaning current  processing)"/>
    <ValueElement Value="R" CodeSystem="HL70207" DisplayName="Restore from archive"/>
    <ValueElement Value="T" CodeSystem="HL70207" DisplayName="Current processing, transmitted at intervals (scheduled or on demand)"/>
</ValueSetDefinition>

And here is my derived XML

<ValueSetDefinition BindingIdentifier="HL70207" Name="Processing mode" Description="Processing mode" Version="2.5.1" Stability="Static" Extensibility="Closed" ContentDefinition="Extensional">
    <ValueElement Value="R" DisplayName="Restore from archive" CodeSystem="HL70207" Usage="P"/>
    <ValueElement Value="T" DisplayName="Current processing, transmitted at intervals (scheduled or on demand)" CodeSystem="HL70207" Usage="P"/>
    <ValueElement Value="I" DisplayName="Initial load" CodeSystem="HL70207" Usage="P"/>
    <ValueElement Value="A" DisplayName="Archive" CodeSystem="HL70207" Usage="P"/>
</ValueSetDefinition>

The value "Not present" is missing from the value set in my derived IG, but PACT is not flagging it

carolinerosin commented 2 years ago

Actually it is another problem. There is no binding for element MSH-11.2 in my derived profile. So this is wrong here image

And PACT should flag that there is a binding missing in the derived profile

carolinerosin commented 2 years ago

Another on that isn't caught: image

The UI shows "CDCREC_R_IZ", but in my profile the value set is named "FHIM_RaceCategory_2"