dmaffitt
commented
7 years ago The codes: iheos-toolkit2/xdstools2/src/main/webapp/toolkitx/environment/default/codes.xml was edited to make the anatomic-region codes and acquisition-modality codes in eventCodeList codeType consistent with the current DICOM standard. Mostly, codingScheme was changed from SNM3 to SRT. A few new codes were added. Several codes were removed from the standard but are left in codes.xml. The standard indicates that they are removed mostly for semantic nit-picking and users need to be aware of legacy values.
There are no more references to SNM3 codes in codes.xml after this clean up.
The data: cd iheos-toolkit2/xdstools2/src 'find . -name "*xml" -type f -print0 | xargs -0 grep -l SNM3' yields 206 files that refer to SNM3.
cd /opt/xdsi/xds-toolkit/01/ImageCache/sim 'find . -type f | xargs dcmdump | grep -i "codingScheme" | grep SNM3' yields 143 references to SNM3.
cd /opt/xdsi/xds-toolkit/01/ImageCache/std 'find . -type f -name "*dcm" | xargs dcmdump | grep -i "codingScheme" | grep SNM3' yields 83 references to SNM3.
There are no more SNM3 codes in iheos-toolkit2/xdstools2/src/main/webapp/toolkitx/environment/default/codes.xml after fixing the codes for eventCodeList.
A cursory review of the affected xml and dcm indicate that these codes are restricted to anatomic-region and acquisition-modality, but I can't be sure there aren't valid uses of SNM3 codes in these files without more detailed analysis.
iheos
The codes.xml file that goes in the external cache is found here: xdstools2/src/main/webapp/toolkitx/environment/default/codes.xml
1) There are other copies in other places, but I think this is the one that is deployed for testing. Check with Bill M to verify that this is the right file to update.
Rad TF 3:4.68.4.1.2.3.2 http://www.ihe.net/uploadedFiles/Documents/Radiology/IHE_RAD_TF_Vol3.pdf defines metadata requirements for submitting radiology documents to a repository. In particular, it defines requirements for the eventCodeList. The coded values are to be taken from the DICOM standard: http://dicom.nema.org/medical/dicom/current/output/pdf/part16.pdf
We have some of the values copied from DICOM to codes.xml; we might even have all of them. Unfortunately, when we first copied them over, we used a coding scheme of SNM3 rather than SRT. I'm not sure why we did this, but it should be repaired.
2) To do the work below, you will create a bugfix branch off master. Please see: https://github.com/usnistgov/iheos-toolkit2/wiki/Branch-and-Commit-Management and https://github.com/usnistgov/iheos-toolkit2/wiki/Develop-branch-commit-log
3) Find/repair all entries in eventCodeList that use SNM3 rather than SRT as the coding scheme. 4) Review the eventCodeList to make sure that all values from the DICOM spec are included. 5) I think there is at least one other entry in codes.xml (might be more) that uses SNM3 rather than SRT as the coding scheme. Look for any such entries and repair them. 6) Before you commit, make sure that your changes did not affect any of the existing XDS-I or XCA-I tests. You will have to find the metadata that is used when KOS objects are submitted. 7) Commit the branch as described above. Send a note to Bill to ask him to perform a merge.