Closed patrick-peer closed 1 year ago
skbhaskarla
commented
1 year ago @patrick-peer, I am testing the updates to codes.xml on the standard version of the XDS Toolkit which is deployed at the IHE Joint Connectathon (Atlanta). (This is separate from XDS-I Toolkit.)
If these updates are needed in the XDS-I Toolkit, you should contact @stl-steve-moore directly.
patrick-peer
commented
1 year ago While preparing for the Connectathon week, I remembered the referenced discussion and noticed that the current version of the codes.xml did not incorporate the mentioned changes. However, I required those changes for an unrelated piece of software back then, and implemented them myself locally, for automated tests. I certainly do not require them for this week ;).
In the long run, I would prefer not having to patch new versions of codes.xml, though, and thought a pull request could be a good idea. If further coordination is required, other processes are better suited, or a change to this specific file in your project is not so smart after all, that's fine too :). Either way, there is no hurry.
Sunil Bhaskarla @.***> schrieb am Mo., 12. Sep. 2022, 22:27:
@patrick-peer https://github.com/patrick-peer, I am testing the updates to codes.xml on the standard version of the XDS Toolkit which is deployed at the IHE Joint Connectathon (Atlanta). (This is separate from XDS-I Toolkit.)
If these updates are needed in the XDS-I Toolkit, you should contact @stl-steve-moore https://github.com/stl-steve-moore directly.
— Reply to this email directly, view it on GitHub https://github.com/usnistgov/iheos-toolkit2/pull/562#issuecomment-1244388989, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABA7W4W7DCKLZ7RF6A7IZTV56G2XANCNFSM6AAAAAAQFZ7CZQ . You are receiving this because you were mentioned.Message ID: @.***>
skbhaskarla
commented
1 year ago I believe the "original version" of the codes.xml is maintained by Lynn or Steve, and the file in the toolkit source code is what I have received from them. For testing purposes, the codes.xml file can be updated locally but updating it in the "master" branch can make it out of sync with the "original" maintainer's copy.
On Mon, Sep 12, 2022 at 4:51 PM patrick-peer @.***> wrote:
While preparing for the Connectathon week, I remembered the referenced discussion and noticed that the current version of the codes.xml did not incorporate the mentioned changes. However, I required those changes for an unrelated piece of software back then, and implemented them myself locally, for automated tests. I certainly do not require them for this week ;).
In the long run, I would prefer not having to patch new versions of codes.xml, though, and thought a pull request could be a good idea. If further coordination is required, other processes are better suited, or a change to this specific file in your project is not so smart after all, that's fine too :). Either way, there is no hurry.
Sunil Bhaskarla @.***> schrieb am Mo., 12. Sep. 2022, 22:27:
@patrick-peer https://github.com/patrick-peer, I am testing the updates to codes.xml on the standard version of the XDS Toolkit which is deployed at the IHE Joint Connectathon (Atlanta). (This is separate from XDS-I Toolkit.)
If these updates are needed in the XDS-I Toolkit, you should contact @stl-steve-moore https://github.com/stl-steve-moore directly.
— Reply to this email directly, view it on GitHub < https://github.com/usnistgov/iheos-toolkit2/pull/562#issuecomment-1244388989 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABA7W4W7DCKLZ7RF6A7IZTV56G2XANCNFSM6AAAAAAQFZ7CZQ
. You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/usnistgov/iheos-toolkit2/pull/562#issuecomment-1244450582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASHCM5AYJNMCGWPXZ7MUB3V56JW5ANCNFSM6AAAAAAQFZ7CZQ . You are receiving this because you commented.Message ID: @.***>
I adapted and extended the default codes.xml file, based on the discussion between Lynn, John and me [1]. Specifically I
[1] https://groups.google.com/g/ihe-xds-implementors/c/2sM-wCCdITI [2] https://groups.google.com/g/ihe-xds-implementors/c/2sM-wCCdITI/m/rmLbh2moBgAJ [3] https://groups.google.com/g/ihe-xds-implementors/c/2sM-wCCdITI/m/6jAUDHxfAwAJ