search

usnistgov / iheos-toolkit2

XDS Toolkit
https://ihexds.nist.gov
45 stars 25 forks source link

DocumentEntries get deprecateded after two "normal" uptades (ITI-57) in Registry simulator #591

Open patrick-peer opened 1 year ago

patrick-peer commented 1 year ago

When I update a Document Entry with ITI-57 in a Registry simulator everything works as expected: The registry contains two Document Entries with the same uniqueId, the old one with Availability Status Deprecated, and the new one with Availability Status Approved. However, when I update the same Document Entry a second time, the Registry simulator contains three Document Entries, every single one having the Availability Status set to Deprecated.

patrick-peer commented 1 year ago

As far as I can tell, my ITI-57 requests should not be the cause for this behaviour, i.e. they do no update the Availability Status. FWIW here is a set of requests, that caused the involuntary deprecation, though: ITI_57_UpdateDocumentSet_Request_1.txt ITI_57_UpdateDocumentSet_Request_2.txt

andrewmccaffreynist commented 1 year ago

Hi,

Can you provide the three Document Entries?

Thanks

From: patrick-peer @.> Sent: Wednesday, August 2, 2023 7:43 AM To: usnistgov/iheos-toolkit2 @.> Cc: Subscribed @.***> Subject: [usnistgov/iheos-toolkit2] DocumentEntries get deprecateded after two "normal" uptades (ITI-57) in Registry simulator (Issue #591)

When I update a Document Entry with ITI-57 in a Registry simulator everything works as expected: The registry contains two Document Entries with the same uniqueId, the old one with Availability Status Deprecated, and the new one with Availability Status Approved. However, when I update the same Document Entry a second time, the Registry simulator contains three Document Entries, every single one having the Availability Status set to Deprecated.

- Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/iheos-toolkit2/issues/591, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE5GE5DJ2XR67VNJ23QZJELXTI4ODANCNFSM6AAAAAA3BEPS4M. You are receiving this because you are subscribed to this thread.Message ID: @.***>

patrick-peer commented 1 year ago

I have no software ready to query for deprecated Document Entries, nor do I know of a way how to extract them from the toolkit => I simply took screenshots of the results from the SimIndexInspector.

I grouped the requests with the resulting changes in the registry (as screenshots) in folders in the attached Zip file [1]. The updated field is DocumentEntry.comments [2].

[1] involuntaryDeprecate.zip [2] https://profiles.ihe.net/ITI/TF/Volume3/ch-4.2.html#4.2.3.2.4

skbhaskarla commented 1 year ago

I found the problem in the Toolkit code. This problem was stemming from changes related to "Adding CP 1190-02 support (Update deprecated DE through RMU)." The code pulls all versions of registry objects with the same DocumentEntry UID but the method always returned only one entry version, in this case the deprecated version 1 not all versions. The fix will be to return correct list of registry objects.