search

usnistgov / iheos-toolkit2

XDS Toolkit
https://ihexds.nist.gov
45 stars 25 forks source link

CT Code Coding scheme oid update #601

Open oliveregger opened 3 months ago

skbhaskarla commented 3 months ago

Hi Oliver,

PR 601 is not what I was expecting. By metadata files, I meant the XDS-I test metadata files, for example: XDS-I-idc-a/metadata-IDCDEPT011-a.xml https://github.com/usnistgov/iheos-toolkit2/compare/develop?expand=1#diff-1d84cc33569c510561445123c9732d7f88fc7539e4c903658a8689bfcf0ff4c0 .

The codes.xml should not be changed, only the test metadata needs to use the correct combination of code, description, etc. The only problem was the incorrect codingScheme. The current urn:connectathon:bppc:foundational:policy must be reverted to the copy before the update, and the codingScheme should be fixed to 1.2.840.10008.2.16.4.

Thanks, Sunil

On Fri, May 24, 2024 at 11:12 AM Oliver Egger @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/usnistgov/iheos-toolkit2/pull/601 Commit Summary

File Changes

(1 file https://github.com/usnistgov/iheos-toolkit2/pull/601/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/usnistgov/iheos-toolkit2/pull/601, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASHCM3DZCF3FI5UX43WGJ3ZD5KGVAVCNFSM6AAAAABIHYJMSSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTKNRUHEZDIOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

skbhaskarla commented 3 months ago

I will update the CodesUpdater tool to fix this issue automatically.