search

usnistgov / mass

Microcalorimeter pulse-analysis software
MIT License
4 stars 0 forks source link

support h5py version 3+ #200

Closed joefowler closed 3 years ago

joefowler commented 3 years ago

Original report by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

Mass tests fail on h5py version 3.1. Here is a link to a failure:

https://bitbucket.org/joe_fowler/mass/addon/pipelines/home#!/results/901

‌

The problem has something to do with writing a string to hdf5, then reading it back. In at least one case it comes back as bytes rather than a string.

joefowler commented 3 years ago

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

Aha, the h5py 3.0 release notes https://docs.h5py.org/en/latest/whatsnew/3.0.html describe changes to string handling: https://docs.h5py.org/en/latest/strings.html

joefowler commented 3 years ago

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

fixed by PR #153

joefowler commented 1 year ago

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Removing milestone: v0.7 (automated comment)