usnistgov / metaschema-xslt

An implementation of the Metaschema information modeling language, in XSLT and XProc
https://pages.nist.gov/metaschema/
Other
3 stars 9 forks source link

Testing and repairs including JSON Schema generation enhancements #119

Closed wendellpiez closed 3 months ago

wendellpiez commented 5 months ago

This PR, when ready, will contain:

And other improvements.

Apologies for the size of this PR!

All Submissions:

Changes to Core Features:

github-actions[bot] commented 5 months ago

XSpec Test Results

  5 files  +  3   93 suites  +53   0s :stopwatch: ±0s 232 tests +127  215 :white_check_mark: +125  17 :zzz: +2  0 :x: ±0  243 runs  +129  225 :white_check_mark: +126  18 :zzz: +3  0 :x: ±0 

Results for commit 4e31191d. ± Comparison against base commit 04a4a4cd.

:recycle: This comment has been updated with latest results.

wendellpiez commented 5 months ago

117 is addressed in the file src/converter-gen/Makefile.

In bash, invoke the XSpecs under testing in this folder with make spec-tests or less directly by make test.

It is also invoked under CI/CD, as shown in results.

Planned next is cleanup, build-out and documentation of all testing. Making this easier for devs can be on this punchlist.

galtm commented 5 months ago

I drilled down into the XSpec Test Results (https://github.com/usnistgov/metaschema-xslt/pull/119/checks?check_run_id=25960758809) by clicking Raw output under There are 229 tests, see "Raw output" for the full list of tests. I wanted to see if the tests ran that https://github.com/usnistgov/metaschema-xslt/pull/87#issuecomment-1986521844 says didn't run in that earlier PR. I searched the raw results for a few of the x:expect labels and they were there. 👍

(The raw results appear to alphabetize the labels, btw.)

wendellpiez commented 5 months ago

Excellent, thanks @galtm. Before this branch is merged, more tests will be placed under the make logic, is the current plan....

wendellpiez commented 3 months ago

This is ready to shake down. It includes lots of new tests, and refactors submodules.