usnistgov / metaschema

Documentation for and implementations of the metaschema modeling language

https://pages.nist.gov/metaschema/

Other

36 stars 19 forks source link

Propose DEBUG to constraint level for developer debugging of models #537

Closed aj-stein-nist closed 8 months ago

aj-stein-nist commented 9 months ago

Committer Notes

Closes #536.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you squashed any non-relevant commits and commit messages? [instructions]
[x] Do all automated CI/CD checks pass?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.
~Have you written new tests for your core changes, as applicable?~ N/A for spec change, we don't have applicable tests for the core module at this time
~Have you included examples of how to use your new feature(s)?~ No, I could consider adding them to a tutorial if this request comes up.

david-waltermire commented 9 months ago

Should this PR update the specification?

aj-stein-nist commented 9 months ago

Should this PR update the specification?

Do we definite the enumeration of all the values in the spec? One moment, let me check that. (I know I avoided that in the tutorial.)

aj-stein-nist commented 9 months ago

Should this PR update the specification?

Do we definite the enumeration of all the values in the spec? One moment, let me check that. (I know I avoided that in the tutorial.)

OK this has been done in the spec in https://github.com/usnistgov/metaschema/pull/537/commits/1c663f233cbe06dc3f6bff8dd03b8ae7c44a5aa2. You were right, not hard to do (let alone find).

My only outstanding question, barring community review async or in a weekly community meeting: should I be updating the marked up web version of the module syntax XML representation? <constraint/> has been rightfully empty for a bit. Should I be editing to add here, or more reasonably in a specific issue, or hold off on that for a bit?

With the changes integrated, I am marking this ready for review and wider public comment.

david-waltermire commented 9 months ago

I'll merge this on 2/21/2024 if there is no additional feedback.