usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

ODD-812: Fixed tree table pre-select problem #109

Closed RayPlante closed 4 years ago

RayPlante commented 4 years ago

This PR deprecates #103 from @chuanlin2018 after I botched an attempt at a rebase. It addresses JIRA issue, ODD-812 ("Datacart pop up only pre-select first level"). From the original PR:

Fixed the problem that only the first level tree table in datacart was checked after user clicks on the download all button.

Almost all code was changed because I changed indent from 2 spaces to 4.

The actual changes are the following functions: this.buildSelectDataArray(this.dataFiles); this.checkNode(this.dataFiles, this.dataArray);

RayPlante commented 4 years ago

@chuanlin2018: Have you/can you test this under oar-docker? I'm having some trouble getting datacart downloads working.

chuanlin2018 commented 4 years ago

I tested in local. Will try docker tomorrow.

Thanks. Chuan

On 1/2/20 10:41 PM, Ray Plante wrote:

@chuanlin2018 https://github.com/chuanlin2018: Have you/can you test this under oar-docker? I'm having some trouble getting datacart downloads working.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usnistgov/oar-pdr/pull/109?email_source=notifications&email_token=AKQHD3AM7NWR4NF2INRC77DQ32XVLA5CNFSM4KCGKYJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAGHPQ#issuecomment-570450878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQHD3DIRNB3J4KRLPOVKN3Q32XVLANCNFSM4KCGKYJQ.

chuanlin2018 commented 4 years ago

I deployed and ran local docker today. The bundle download worked fine for id 50FF29D41202478EE0531A57068105821843. I got "Ooops..." error for JANAF ECBCC1C1301D2ED9E04306570681B10735 The log that I added for testing showed: "No Files added in the Bundle, there are problems accessing URLs." Seems working but I need to modify the UI to display the proper message.

RayPlante commented 4 years ago

The issue I was running into was nginx size limit. Once fixed, downloads worked