search

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Fix/odd845 about page link #113

Closed chuanlin2018 closed 4 years ago

chuanlin2018 commented 4 years ago

http://mml.nist.gov:8080/browse/ODD-845

This branch fixed the about page link.

RayPlante commented 4 years ago

Note that this fix doesn't quite do it: if you do a curl on a landing page (which is what a bot will see without running the Javascript), the link comes out as href="/pdr/pdr/about". This is because the nginx proxy filters the output from the PDR server, substituting href="/ whith href="/pdr/; see the the location /od/id/ section of the nginx config file. Nevertheless, this is also the case on the current LPS deployed to production at the moment. I suspect the proper solution will require some broader thinking that takes into account the issue of the error page URL that we discussed earlier today. Thus, apart from one issue I'll raise in my next comment, I'm inclined to approve this patch.

RayPlante commented 4 years ago

@GRG2 I thought I would point out a difference between what we looked at in our developer's meeting today on the production system, and the pending release candidate. On production right now (ver. 1.2.7), the landing page top navigation looks like this: pdr-about-nav1 2 7

In the pending 1.3.0 rc that this PR would go into, the navigation looks like this: pdr-about-nav1 3 0

In both cases, the link goes to the about page. In the newer version, house icon link has a tool tip, "Go to home page". In the later case, calling the About page the home page doesn't seem quite right. If that's what we want to label it as (for now), then I think the tool tip should specify this as the "Repository home page" (as distinguished from the portal's home page).

So what would we rather go with:

Keep in mind that we just decided to add another link, "Contact".

chuanlin2018 commented 4 years ago

"About" seems more clear to me. I think I have never fully understood how this about page link works :) What I did was made it the same as it was in integration which was current production version. Ray or Deoyani may explain to me one more time sometime. For the "Contact" link, when I have questions about a product, I usually click on "Support" menu item in their website. In the support page usually I can find phone number, email, FAQ, etc. Some support page allow me to submit message without pop up email client.