search

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

508 compliance #116

Closed chuanlin2018 closed 4 years ago

chuanlin2018 commented 4 years ago

http://mml.nist.gov:8080/browse/ODD-792

Changes to color and button labels for 508 compliance. Based on integration13.

RayPlante commented 4 years ago

@chuanlin2018 please resolve this conflict.

chuanlin2018 commented 4 years ago

Resolved. I saw you changed "integration13" to "integration". So "integration" is now restructured code.

RayPlante commented 4 years ago

Did you really mean to choose pink here? Spectacle z30096

RayPlante commented 4 years ago

To answer my own question, I guess the answer is, yes, from looking at the file. I applaud you for your boldness, but I think we need a different color here. What is the recommendation this color change is addressing?

chuanlin2018 commented 4 years ago

In light background, a visited link is usually in dark pink color. So for dark background, I need to change it to lighter color for 508 compliance. I don't like this color either. Let's discuss in the standup meeting to pick a different color.

RayPlante commented 4 years ago

Do we need to set a visited color? Can we just keep it white?

chuanlin2018 commented 4 years ago

Sure. That's a good option.

RayPlante commented 4 years ago

Cool. Let's go with that. Thanks!

chuanlin2018 commented 4 years ago

I like your idea. Actually a menu item should always be the same color. Will check in the change soon.

RayPlante commented 4 years ago

FYI, I tested both under apps and publish as well as with editing enabled.

chuanlin2018 commented 4 years ago

Great. I tested in local oar-docker and everything appeared to be working fine.