usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

LPS Restructuring Con't: New Tools Component #120

Closed RayPlante closed 4 years ago

RayPlante commented 4 years ago

This PR is part of an ongoing effort at restructuring the angular Landing Page Service (LPS) app in an effort to improve maintainability and ease further evolution of the presentation. Its overall goal is to distribute the current LandingComponent into several smaller apps that are aggregated together. This PR, in particular, breaks out the right-hand tools menu into is own component, leaving the LandingComponent to handle just the main body of the landing page content. While implementation of the menu is largely unchanged, it is a helpful precursor to replacing the tool bar with an implementation that is primeng-free (as the primeng components don't work with the server-side rendering).

The change provided by the PR is summarized in the following diagrams.
toolmenu-extraction

In particular, the changes include:

(As a preview, the next restructuring PR will split the LandingComponent into the different navigable sections.)

To review, please:

  1. review this PR description
  2. scan the code differences as needed for any obvious issues
  3. run standalone with editing turned on and off to ensure proper layout
  4. run under oar-docker/apps to ensure proper integrated behavior
RayPlante commented 4 years ago

Sorry, I accidentally created this PR from a personal branch (RayPlante) rather than from usnistgov. I've pushed this same branch to usnistgov for your convenience.