Closed chuanlin2018 closed 4 years ago
@chuanlin2018 Please test this under oar-docker--that's where it counts at the end of the day.
I would recommend the following process:
Will do.
Assume I still use feature/ODD-774-customization-api branch...
If the branch for this PR was derived from oar-pdr integration
(which I believe is true), then you should use the integration
(or rel/1.3.X
) oar-docker branch.
Ah ok. feature/ODD-774-customization-api is for new workflow, correct?
feature/ODD-774-customization-api is for new workflow, correct? Correct!
From: chuanlin2018 notifications@github.com Sent: Wednesday, April 29, 2020 4:57 PM To: usnistgov/oar-pdr oar-pdr@noreply.github.com Cc: Plante, Raymond L. (Fed) raymond.plante@nist.gov; Comment comment@noreply.github.com Subject: Re: [usnistgov/oar-pdr] ODD-861 Fix bundle download error handling (#121)
Ah ok. feature/ODD-774-customization-api is for new workflow, correct?
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/oar-pdr/pull/121#issuecomment-621459409, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH245HGHNYYKZTY6WAI373RPCIAPANCNFSM4LAUBJ5Q.
Made following changes:
The help button next to the three control buttons now has content in it, Service side error was fixed, Used “theme” field for topic instead of “topics” field Fixed the big white space when server side return 404
@chuanlin
These last changes you mentioned are related to customization, this is download Error related branch. Are you using same branch for both?
Sorry, I copied wrong text. Should be these changes:
Ok sounds good. I tested locally works as expected.
http://mml.nist.gov:8080/browse/ODD-861
This check in is to fix the error handling of bundle downloading. Current version does not display details returned from bundle plan and error massage does not contains any detail info.
Here are the changes:
[05/08/2020] updates:
=== Tested in local oar-docker. Test cases:
JANAF (Not downloadable. Should return error) ECBCC1C1301D2ED9E04306570681B10735
Quantum dot data (Downloadable) 66492819760D3FF6E05324570681BA721894
Here is oar-docker config:
_app: app_dir: . ingestdata: service_root: rmm/ingestdata components: