search

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

ODD-861 Fix bundle download error handling #121

Closed chuanlin2018 closed 4 years ago

chuanlin2018 commented 4 years ago

http://mml.nist.gov:8080/browse/ODD-861

This check in is to fix the error handling of bundle downloading. Current version does not display details returned from bundle plan and error massage does not contains any detail info.

Here are the changes:

  1. Added background image to "Download Manager" title bar and placed the control buttons in the title bar;
  2. Removed the top error message line and the detail error message table;
  3. Placed tech support contact at the right side of the message header. When user click on the email link, email client will pop up with error message in certain format that we discussed;
  4. In the file tree table, placed the download icons in a new "Action" column. The icon will blinking if the file is been downloading.
  5. In the file tree table, if a file is been downloading, a spinner will appear to the left of the status "downloading". if any file failed to download, the status "failed" will be clickable. When user clicks on it, it will pop up a window with detail info: file path, url and message.
  6. In the file tree table, changed "Status reset" button from one single little icon to "reset" and placed it to the right of the status header column.

[05/08/2020] updates:

  1. Move the action column before “Media Type”
  2. For single file download update text in tooltip to “Download this file”
  3. Update status with icon matching same color as text

=== Tested in local oar-docker. Test cases:

JANAF (Not downloadable. Should return error) ECBCC1C1301D2ED9E04306570681B10735

Quantum dot data (Downloadable) 66492819760D3FF6E05324570681BA721894

Here is oar-docker config:

_app: app_dir: . ingestdata: service_root: rmm/ingestdata components:

RayPlante commented 4 years ago

@chuanlin2018 Please test this under oar-docker--that's where it counts at the end of the day.

I would recommend the following process:

  1. Add some files from the JANAF dataset and some from the "Quantum dot data" dataset to your datacart
  2. First select files from the JANAF dataset in the data cart and attempt a download. None of these will download, no zips can be created. Is the messaging as you expect?
  3. Now select files from both datasets. Since the quantum dot data is downloadable, you should be able to create at least one zip with those files. Is the messaging as you expect for this case?
chuanlin2018 commented 4 years ago

Will do.

chuanlin2018 commented 4 years ago

Assume I still use feature/ODD-774-customization-api branch...

RayPlante commented 4 years ago

If the branch for this PR was derived from oar-pdr integration (which I believe is true), then you should use the integration (or rel/1.3.X) oar-docker branch.

chuanlin2018 commented 4 years ago

Ah ok. feature/ODD-774-customization-api is for new workflow, correct?

RayPlante commented 4 years ago

feature/ODD-774-customization-api is for new workflow, correct? Correct!

From: chuanlin2018 notifications@github.com Sent: Wednesday, April 29, 2020 4:57 PM To: usnistgov/oar-pdr oar-pdr@noreply.github.com Cc: Plante, Raymond L. (Fed) raymond.plante@nist.gov; Comment comment@noreply.github.com Subject: Re: [usnistgov/oar-pdr] ODD-861 Fix bundle download error handling (#121)

Ah ok. feature/ODD-774-customization-api is for new workflow, correct?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/oar-pdr/pull/121#issuecomment-621459409, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH245HGHNYYKZTY6WAI373RPCIAPANCNFSM4LAUBJ5Q.

chuanlin2018 commented 4 years ago

Made following changes:

The help button next to the three control buttons now has content in it, Service side error was fixed, Used “theme” field for topic instead of “topics” field Fixed the big white space when server side return 404

deoyani commented 4 years ago

@chuanlin

These last changes you mentioned are related to customization, this is download Error related branch. Are you using same branch for both?

chuanlin2018 commented 4 years ago

Sorry, I copied wrong text. Should be these changes:

  1. Move the action column before “Media Type”
  2. For single file download update text in tooltip to “Download this file”
  3. Update status with icon matching same color as text
deoyani commented 4 years ago

Ok sounds good. I tested locally works as expected.