search

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Restore "View Metadata" function #128

Closed RayPlante closed 4 years ago

RayPlante commented 4 years ago

In the last PDR-LPS code restructuring iteration, the "View Metadata" item in the right-side tools menu stopped working. This PR restores its functionality.

Note that metadata visualization is expected to change in further iterations of the code restructuring.

chuanlin2018 commented 4 years ago

I didn't see viewmetadata() in landing.component.ts be referenced anywhere. Not sure if we still need it. Another thing I noticed when I tested locally was that the fix to "Resources by Authors" was not in this branch. It was not in the integration branch either. So it's not caused by this fix. Probably it was missed out when we did restructuring. Everything else looks good to me.

RayPlante commented 4 years ago

Yes, I think viewmetata() is superfluous; I expect to remove it in the next restructuring iteration.

If you are good with this, can you approve the review?