usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

ODD-881: don't let file examination override download URL #136

Closed RayPlante closed 4 years ago

RayPlante commented 4 years ago

This PR addresses ticket ODD-881 that describes how during the publication process download URLs can get overridden when files are examined to extract extra metadata. This was seen with new-style identifiers (e.g. ark:/88434/mds2-7777) in which a download URL that appears in the pod file like, say, https://data.nist.gov/od/ds/mds2-7777/README.txt, would get replaced in the NERDm file with https://data.nist.gov/od/ds/ark/88434/mds2-7777/README.txt. While both URLs work in the PDR, the former is preferred.

RayPlante commented 4 years ago

This is a bit tricky to test. I've tested this under oar-docker using the demo app and confirmed that download URLs are not getting overridden and preservation completes without issue.