usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

ODD-910: Fix Landing Page Version Links and Labeling #154

Closed RayPlante closed 4 years ago

RayPlante commented 4 years ago

A recent submission (mds2-2225) highlighted some problems with the display versions on the landing page:

This is the subject of ODD-910 which is addressed in this PR.

This problem has been addressed in a somewhat temporary way:

To test under oar-docker, it is recommended that you load a particular record that demonstrates the problem being fixed (process described below). Further, it is recommended to to first run oar-docker without the fix. In detail, do the following:

  1. Build and start locally a 1.4 version of oar-docker/apps without updating the deployment.yml file (i.e. use either the current integration or main branch).

  2. Copy the test record from the oar-pdr PR branch, angular/src/assets/mds2-2225.json, to your current directory so that you can load it.

  3. Load. record with this curl command:

    curl -vk -H 'Authorization: Bearer LOCALAUTHKEY' --data @mds2-2225.json https://localhost:8099/ingest/nerdm

    This should return status 201 (Accepted).

  4. Access the landing page via https://localhost/od/id/mds2-2225

  5. Note the problems:

    • A message about a newer version, 1.2.0, being available will appear, even though the current version is 1.3.0
    • Open up the version history and notice the "View..." links.
  6. Now stop the apps app, edit the deployment.yml file to use this PR branch, rebuild, and run.

  7. Reload the landing page for mds2-2225. (You should not need to reload the record via curl.)

  8. Note the correction of problems:

    • The newer version message does not appear.
    • Links in the version history are no longer shown.