usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Do not check metrics when edit enabled #193

Closed chuanlin2018 closed 3 years ago

chuanlin2018 commented 3 years ago

This check in added a guard to get metrics function to prevent loading metrics data when edit is enabled.

Since this is a fairly simple change I didn't test it in local oar docker...

chuanlin2018 commented 3 years ago

You are right. I originally thought about adding some error handling code but forgot later on... will do it today.

chuanlin2018 commented 3 years ago

Added dataset metrics error handling.

chuanlin2018 commented 3 years ago

Ah you are right. Will fix it.

chuanlin2018 commented 3 years ago

Tested locally with/without "?editEnabled=true" in URL.