search

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Fix/odd1003 footer update #209

Closed chuanlin2018 closed 2 years ago

chuanlin2018 commented 3 years ago

http://mml.nist.gov:8080/browse/ODD-1003

In this branch, the social media and link data of the footer was placed in a JSON file under assets/site-constants/. This design allow us to modify footer links without change the code.

I removed some detailed testing code in footer unit test so if we modify the JSON file, the unit test won't fail.

To test, run it in local docker or run it locally using npm. Make sure server-side rendering has no error.

chuanlin2018 commented 3 years ago

You are right. "In browser" guard is not necessary. We only need it for PrimeNG. There are three fixes in this check in:

  1. Remove "in browser"
  2. Some changes for better unit test
  3. Updated copyrights link
chuanlin2018 commented 2 years ago

Sure. Fixing now.

chuanlin2018 commented 2 years ago

Tested locally. Since this is a simple change I didn't test it in docker.