usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Support linkless ("in press") references and fix layout problems #247

Closed RayPlante closed 2 years ago

RayPlante commented 2 years ago

The main motivation behind this PR is to properly display references that do not include a link to the thing being reference--e.g. a paper that is still "in press". Previously, if a NERDm reference did not include a location property (which provides the URL to the cited thing), the landing was still rendering it as a link, which by default went to the PDR home URL. With this PR, it is now rendered as regular text. Supporting this feature required an update to the NERDm core schema (see oar-metadata PR#50).

I took this opportunity to fix a few other reference rendering issues:

To test these changes, I've set up a special oar-docker branch, test/inpress-refs. After running localdeploy and oarctl local build, run the following script to load three test records:

   data/load_nerdm.sh data/pdr/nerdm/*.json

(There is no need to start from scratch.)

Next view the following landing pages and confirm proper rendering as described below:

chuanlin2018 commented 2 years ago

Working on it...

chuanlin2018 commented 2 years ago

Not sure where to change the status to "Approved". Merge anyway...