usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Fixed keyword filter issue. #255

Closed chuanlin2018 closed 2 years ago

chuanlin2018 commented 2 years ago

This check in fixed following issues:

  1. When user selected more than one keyword in the keyword filter, nothing showed up in the search result.
  2. After above fixed, when user selected two keywords in the keyword filter then removed one of them, the search result will be empty.

1 was because that the search string was not parsed. In SDP, it was parsed in the server side but here we need to parse it in the memory.

2 was because the suggested keyword lookup table only contained the suggested keywords of latest selected keyword. Once it was removed, the app was unable to locate the original keywords for search.

To test, run the app locally and browse http://localhost:4200/od/id/mds9911.

deoyani commented 2 years ago

@chuanlin2018 The sample data does not work at http://localhost:4200/od/id/mds9911 I tried running everything locally. Is the sample data checked in?

chuanlin2018 commented 2 years ago

@deoyani :Forgot to mention, when you test it locally, set useMetadataService: true in the environment.ts file. Then the app will use oardev as back end.

Screen Shot 2022-06-03 at 2 59 19 PM

deoyani commented 2 years ago

@chuanlin2018 Thanks! For now I will test this way but Ideally we should be able to run with local docker everything. I will put an example in such a way that local RMM should be able to provide that metadata.