Closed chuanlin2018 closed 2 years ago
@chuanlin2018 I tested all the changes except the metrics spinner etc, it is not obvious to me, can you confirm whether metrics API is called ? I do not see in the network calls in javascript console. Try using 8C401B5C708647B8E05324570681610A2081 as it has the data for metrics in oardev.
Let me check.
I just ran it locally and I realized that line 206 in styles.scss need be commented out in order to see the spinner. I will check in the fix soon:
This is the url to get metrics data: https://oardev.nist.gov/rmm/usagemetrics/files?exclude=_id&include=ediid,filepath,success_get,download_size&ediid=8C401B5C708647B8E05324570681610A2081
Thats right but it does not seem to get called when I was testing this branch locally.
The spinner class in styles.scss is used by other components. I renamed the one in metricsinfo css. Now it should work.
The link was copied from console log. I added a console log right before the url was called...
Just checked in the fix to the spinner css.
The spinner might be hard to see if the server response very quick. To test it locally I set a timeout to simulate the delay in landingpage.component.ts:
@chuanlin2018 there is error in one of the tests, can you check and confirm?
It didn't get to Angular test yet. I just restarted the test...
It failed again in Python tests: I am not sure how to fix it except restart the process...
It looks like we may have it an docker hub access limit; we may need to wait until tomorrow to rerun
All tests have now passed.
Everything works! Metrics spinner needs testing on the server.
This version fixed following issues. It also included the change in PR#255 (keyword filter dropdown display nothing when user removed one selected keyword)