usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Fixed issues found in the test for release #307

Closed chuanlin2018 closed 1 year ago

chuanlin2018 commented 1 year ago

There is no Jira ticket for this checkin.

This check in fixed following issues:

Forensics Science Data page:

  1. https://testdata.nist.gov/lps/pdr0-0001

When user clicked on "Clear All" in the filters panel, the search result was not reset and all filter categories were expanded (suppose only the category at the top expanded).

  1. Extra dot at the end of the author list:

Barbara Guttman, Gregory Fiumara, Edward Sisco, Peter Vallone, Steve Lund, Melissa Taylor, Hans Soons..

Regular landing page:

  1. The drag bar at the bottom of the data table missing sometime.

    Now it will show up when there are more than 25 items in the table - when scroll bar enabled, the drag bar will also show up.

  2. In the case of large data set, when user expanded a folder, the table window will be set to minimum which only one line visible. The new behavior is that if the window is in minimum height when user expand a folder, it will be set to maximum height. Otherwise the height will be set to maximum.

  3. The search glass icon does not have alt text.

chuanlin2018 commented 1 year ago

I just changed the logic. If any node was expanded, and table height is minimum height, set it to maximum height. Otherwise leave the table height as it is.

chuanlin2018 commented 1 year ago

I modified the logic to handle following test cases: Has only one file 54AE54FB37AC022DE0531A570681D4291851

Has two files: 26DEA39AD677678AE0531A570681F32C1449

Has multiple top folders mds2-2437 5BD6911D381AB2E3E0531A57068151FA1869

Has only one top level folder mds2-2459

Has many top level files FF429BC1785F8B3EE0431A570681E858206

Has multiple top level files and folders mds2-2116

RayPlante commented 1 year ago

Yes--this is more like what I was thinking. Testing now...