search

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Handle metrics that has no filepath #323

Closed chuanlin2018 closed 5 months ago

chuanlin2018 commented 6 months ago

Issue: landing page crashed when metrics data didn't have filepath info. Example: https://testdata.nist.gov/od/id/66AF4AFEA96764C4E0532457068100261895 Fix: Check filepath attribute before using it. Testing: To test using testdata.nist.gov as backend, in environment.ts set useMetadataService: true, useCustomizationService: true and replace data.nist.gov with testdata.nist.gov. Test samples: http://localhost:4200/metrics/mds2-2124 http://localhost:4200/lps/mds2-2124 http://localhost:4200/metrics/576CE869311197F3E0531A570681C5C71857 http://localhost:4200/lps/576CE869311197F3E0531A570681C5C71857

RayPlante commented 6 months ago

This PR has some conflicts with #320 . Can you try resolving them? (Try merging the two branches together to see the conflicts.)

chuanlin2018 commented 6 months ago

Will do.

chuanlin2018 commented 6 months ago

Fixed. Sorry for the delay. It took me a while to figure out what had been changed in both PRs...