usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software
11 stars 10 forks source link

Hide download button for folders #325

Closed chuanlin2018 closed 3 months ago

chuanlin2018 commented 3 months ago

This check in fixed following issue: Issue: In the file list, download button showed up for folders which should not. The column title that sometime display "Status" and sometime "Access" was by design. The default name is "Status". But when access level is 'restricted public', it changes to "Access". Here is the code: if(this.record['accessLevel'] === 'restricted public') { this.checkAccessPageType(); this.cols[3]['header'] = "Access"; } To test the app locally, set the following config in environment.ts: useMetadataService: true, useCustomizationService: true And change data.nist.gov to testdata.nist.gov if necessary.

Test case: http://localhost:4200/lps/mds2-2909 (in testdata.nist.gov) http://localhost:4200/lps/mds2-2645 (in data.nist.gov)

RayPlante commented 3 months ago

@chuanlin2018 (& @GRG2): I see. I don't remember what our reasoning was at the time, but it looks like we had some. I think, though now, now that we see it, we prefer "Access" across the board. Do you think you could make that change?

Meanwhile, I'm testing the download link removal for folders.

chuanlin2018 commented 3 months ago

Sure.

chuanlin2018 commented 3 months ago

Changed.

chuanlin2018 commented 3 months ago

Confirmed in testdata.