ODD-712: close bag's log on failure

usnistgov / oar-pdr

The NIST Open Access to Research (OAR) Public Data Repository (PDR) system software

11 stars 10 forks source link

ODD-712: close bag's log on failure #63

Closed RayPlante closed 5 years ago

RayPlante commented 5 years ago

ODD-712 briefly describes how when a fatal failure occurs during preservation, the bag's internal log file does not get closed. This causes problems removing the failed bag when the bag is on an NFS-mounted system, as it is on the test and production platforms.

This small fix corrects this bug. This PR also includes a fix to the scripts/testall.python script that ensures that it can run standalone.

RayPlante commented 5 years ago

This is hard to test definitively except on the test and production systems that feature NFS-mounted disks. Tests under oar-docker's demo app indicate that this PR does not break anything. Will merge.