search

usnistgov / oscal-cli

A simple open source command line tool to support common operations over OSCAL content.
Other
42 stars 19 forks source link

OSCAL-CLI (system-characteristics/prop (cloud-deployment-model) #185

Closed Telos-sa closed 9 months ago

Telos-sa commented 1 year ago

Describe the bug

Model description shows "hybrid-cloud" as an acceptable option,

image

However oscal-cli throws an error that hybrid-cloud is not does not match available options

[ERROR] [/system-security-plan/system-characteristics[1]/prop[8]/@value] Value 'hybrid-cloud' doesn't match one of 'community-cloud, government-only-cloud, other, private-cloud, or public-cloud' at path '/system-security-plan/system-characteristics[1]/prop[8]/@value'

Attached is the SSP package with the corresponding issue for review.
FedRAMP---Major-System-Boundary_OSCAL-export_20230823.zip

Who is the bug affecting

Anyone with a hybrid cloud that uses the oscal-cli to validate

What is affected by this bug

Modeling, Tooling & API

How do we replicate this issue

Validate the provided SSP with 1.1.0 OSCAL-cli

Expected behavior (i.e. solution)

this should not generate an error, as it follows the requirements outlined: https://pages.nist.gov/OSCAL-Reference/models/v1.1.0/system-security-plan/json-reference/#/system-security-plan/system-characteristics/props

Other comments

No response

Revisions

No response

aj-stein-nist commented 1 year ago

I see this is in the OSCAL repository. As this is a report about processing of data instances with the CLI, I will transfer this to the oscal-cli repository. Thanks for your report.

aj-stein-nist commented 1 year ago

Thanks again for the report, @Telos-sa. I do see you are correct in regards to the report in the disparity between the document string for the name, but missing enumeration for its value. I will open a cross-referenced issue to update the model, then move up liboscal-java with the new model changes once it is ready.

I am sure you know you can use "other" or the additional values, per your preference, as a workaround, but follow this issue and once it is closed, that means a released version of the CLI has the updated schema that will resolve this bug. Thanks again.

aj-stein-nist commented 9 months ago

Judging from previous comments, this issue can be resolved when a patch release includes an updated version of the model.